Anon Archived Does Voat not unit test or is it just not included in the GitHub repo? (github.com)
submitted ago by 225485?
Posted by: 225485?
Posting time: 5.4 years ago on
Last edit time: never edited.
Archived on: 2/12/2017 1:51:00 AM
Views: 991
SCP: 19
20 upvotes, 1 downvotes (95% upvoted it)
Anon Archived Does Voat not unit test or is it just not included in the GitHub repo? (github.com)
submitted ago by 225485?
view the rest of the comments →
[–] ptd 0 points 1 point 1 point (+1|-0) ago
Yeah no doubt. From what I understand they started this project as a learning experience in college or something. I skimmed through some of their code and from what I can see I would focus on a few things:
[–] Cuddlefluff ago
They also needs to take a serious look at their use of try-catch because it is wrong :P
This is not how exceptions are supposed to be handled. If you have an unhandled exception, there's an entire functionality in ASP.NET to handle that eventuality. Removing the "catch-all" clauses will reduce code duplication and improve debugging and logging.
[–] ptd ago
Yep, sure. I mean, in all you can find yourself refactoring forever. There's always room to improve something, ya know? I think they're doing a great job of fighting off the huge influx of users, bots, and attackers, though.