You are viewing a single comment's thread.

view the rest of the comments →

0
1

[–] ptd 0 points 1 point (+1|-0) ago 

Yeah no doubt. From what I understand they started this project as a learning experience in college or something. I skimmed through some of their code and from what I can see I would focus on a few things:

  1. Abstract business, data, and infrastructure logic into separate projects. This will make writing for scalability easier in the future if they decide to move to a queue driven pattern or something. It will also make the code easier to read and more modular.
  2. Remove left over VS template code.
  3. Move scripts/styles/etc to a CDN.
  4. Use some sort of DI/IoC with Autofac, Structuremap, etc.
  5. Get ready for a load balanced environment. If they use something like azure wep apps or azure cloud services this is pretty easy. Even SignalR has a single line configurable backplane with SQL, Azure Service Bus, or Redis. It's actually a fairly cheap solution.

0
0

[–] Cuddlefluff ago 

They also needs to take a serious look at their use of try-catch because it is wrong :P

try
{
    ....
}
catch (Exception) <-- BAD!
{
    ....
}

This is not how exceptions are supposed to be handled. If you have an unhandled exception, there's an entire functionality in ASP.NET to handle that eventuality. Removing the "catch-all" clauses will reduce code duplication and improve debugging and logging.

0
0

[–] ptd ago 

Yep, sure. I mean, in all you can find yourself refactoring forever. There's always room to improve something, ya know? I think they're doing a great job of fighting off the huge influx of users, bots, and attackers, though.