You are viewing a single comment's thread.

view the rest of the comments →

0
4

[–] ptd 0 points 4 points (+4|-0) ago 

It looks like they sort of do. If you look in the UnitTests.cs file there's a few tests in there.

https://github.com/voat/voat/blob/master/Whoaverse/UnitTests/UnitTests.cs

But it doesn't seem like it's something they do consistently (last commit was May 19).

0
1

[–] pkhagah 0 points 1 point (+1|-0) ago 

I think they are doing a huge refactor now and will eventually get to unit tests.

0
1

[–] ptd 0 points 1 point (+1|-0) ago 

Yeah no doubt. From what I understand they started this project as a learning experience in college or something. I skimmed through some of their code and from what I can see I would focus on a few things:

  1. Abstract business, data, and infrastructure logic into separate projects. This will make writing for scalability easier in the future if they decide to move to a queue driven pattern or something. It will also make the code easier to read and more modular.
  2. Remove left over VS template code.
  3. Move scripts/styles/etc to a CDN.
  4. Use some sort of DI/IoC with Autofac, Structuremap, etc.
  5. Get ready for a load balanced environment. If they use something like azure wep apps or azure cloud services this is pretty easy. Even SignalR has a single line configurable backplane with SQL, Azure Service Bus, or Redis. It's actually a fairly cheap solution.

0
1

[–] dwarmia 0 points 1 point (+1|-0) ago 

I am not part of the team and they don't know me :)

But i am looking the source code really close, i might start writing unit tests soon.

PS : Test Driven Rulez !